Skip to content

Fix overwriting of default CMake variants #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lceWolf merged 1 commit into from
Feb 28, 2026
Merged

Fix overwriting of default CMake variants #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions lua/cmake-tools/variants.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,19 +224,14 @@ function variants.build_arglist(variant, cwd)
local function build_simple(build_type)
return { "-D", "CMAKE_BUILD_TYPE:STRING=" .. build_type }
end

-- start building arglist

-- check if the chosen variants is one of the defaults
for _, defaultvar in pairs(DEFAULT_VARIANTS) do
if variant == defaultvar then
return build_simple(variant) -- if so, build the simple arglist and return
end
end

-- otherwise, find the config file to parse
local config = variants.parse(cwd)
if not config then
-- check if the chosen variants is one of the defaults
for _, defaultvar in pairs(DEFAULT_VARIANTS) do
if variant == defaultvar then
return build_simple(variant) -- if so, build the simple arglist and return
end
end
return {} -- silent error (empty arglist) if no config file found
end

Expand Down