Fix overwriting of default CMake variants#367
Merged
lceWolf merged 1 commit intoCivitasv:masterfrom Feb 28, 2026
Merged
Conversation
Collaborator
|
LGTM, thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following issue:
Preconditions
Steps:
Expected: The option change is reflected in CMakeCache.txt.
Actual: The change is not reflected.
Here is a small hello world project for easier testing: hello.zip
I noticed that cmake-tools generates a default argument list if the variant name happens to match one of the defaults. I would assume this is intended behavior when no YAML file exists, but it also occurs when the file is present. I tested vscode-cmake-tools, and there the settings change works correctly.