Skip to content

use cubic bezier curves for smoother edge rendering#545

Draft
dlyongemallo wants to merge 1 commit into
zxcalc:masterfrom
dlyongemallo:266-curves
Draft

use cubic bezier curves for smoother edge rendering#545
dlyongemallo wants to merge 1 commit into
zxcalc:masterfrom
dlyongemallo:266-curves

Conversation

@dlyongemallo

Copy link
Copy Markdown
Contributor

No description provided.

@jvdwetering

Copy link
Copy Markdown
Collaborator

Just an FYI that a lot of the functionality and look of ZXLive is based on that of TikZiT which also uses cubic curves. It might be worthwhile to copy as much as possible the exact parameters from TikZiT so that a diagram imported from there continues to look the same in ZXLive.

https://github.com/tikzit/tikzit

@dlyongemallo

Copy link
Copy Markdown
Contributor Author

The self-loop behaviour before this change does not match TikZit. It has a weight of 0.707 (1/sqrt(2)) compared to TikZit's 1.0. Changing this would resize existing self-loops in saved files. Is that desirable, or should it be left alone?

@jvdwetering

Copy link
Copy Markdown
Collaborator

I think that is such a minor issue that we can just take that change and make it match tikzit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants