feat(charts): add UI settings category to all chart schemas (+ redis mutable fix)#293
Open
arunesh-j wants to merge 2 commits into
Open
feat(charts): add UI settings category to all chart schemas (+ redis mutable fix)#293arunesh-j wants to merge 2 commits into
arunesh-j wants to merge 2 commits into
Conversation
Adds the fixed `category` key (runtime|compute|environment|advanced) to the top-level properties of every chart that has a values.schema.json but wasn't yet categorised — the same standardisation service/cron-job already carry. helm-manager reads this to group fields into Settings tabs; it's UI-only metadata (a non-standard JSON-Schema keyword Helm ignores at install time), so no repackaging or Chart.yaml bump is needed. Mapping follows the service rules: resources/diskSize/replication/replicas → compute; version/services/ports → runtime; auth/connections/env → environment; customConfig/tls/operator/bundled-deps/scheduling → advanced. 87 additive insertions across 21 charts; no existing lines changed.
The four resources cpu/memory fields had "mutable": "true" (a quoted string). helm-manager asserts props["mutable"].(bool), which fails on a string, so the fields were never emitted and redis resources didn't show in the settings form. Change them to boolean true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the UI settings
categorykey to every chart schema that has avalues.schema.jsonbut wasn't yet categorised, using the fixed vocabulary the ZopDay imported-service Settings UI standardises on:runtime·compute·environment·advanced. Also fixes amutabletypo in the redis schema.serviceandcron-jobalready carry these categories (merged earlier); this covers the remaining 21 charts.Why
helm-manager reads
categoryoff each top-level property and the ZopDay Settings drawer groups fields into tabs by it. Without a category, a chart's fields don't surface in the tabbed Settings view. This is UI-only metadata —categoryis a non-standard JSON-Schema keyword that Helm ignores at install time, so no repackaging orChart.yamlbump is needed (helm-manager reads the schema from the branch/main source, not the packaged.tgz).Mapping (top-level properties)
resources,diskSize/disk_size,replication, per-component resource objects (master,slave,zero,alpha), schedulingversion,services/service, portsauth,supersetNode(db/redis connections)customConfig/customMyCnf,tls,zookeeper,solr-operator, bundled dependencies (postgres/redis/mysql),init, jupyterhubhub/proxy/prePuller/cull, uptimeprometheus/targetsimage/nameleft uncategorised (hidden from settings, same asservice)redis
mutablefixThe four
resources.{requests,limits}.{cpu,memory}fields had"mutable": "true"(a quoted string). helm-manager assertsprops["mutable"].(bool), which fails on a string, so those fields were never emitted and redis resources didn't render. Changed to booleantrue.Notes