fix: Accurate bookmark chapter titles and page numbers#143
Merged
Conversation
znelson
force-pushed
the
bookmark-calc
branch
2 times, most recently
from
July 16, 2026 17:12
26af65f to
02567b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve the title page-accurately (getTocIndexForPage) so a bookmark in a multi-chapter spine shows its own sub-chapter, not the spine's first, and show chapter-relative pages instead of spine-local ones. Adds a non-destructive query-mode cache load (Section::loadCachedPageCount / SpineItem::loadForQuery) so browsing bookmarks can't invalidate reader caches.