fix: Unify book-progress percent across reader screens#142
Merged
Conversation
znelson
force-pushed
the
percent-calc
branch
2 times, most recently
from
July 16, 2026 16:59
0512e20 to
8a234d1
Compare
znelson
enabled auto-merge (squash)
July 16, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status bar used a 1-based intra-spine page fraction while the menu, go-to-percent, screenshot, and bookmark list used 0-based, so the same position read differently per screen and the 0-based ones never hit 100% at book end. Route all five through
Epub::calculateProgressForPage(1-based).