feat(identity): add token lifespan percentage - #8
Merged
Conversation
# Conflicts: # ws/identity/retriever.go
Instead of individual fields
Reduces chances to use an expired token when close to the expiration time.
zmoog
force-pushed
the
zmoog/feat/refresh-token
branch
from
September 29, 2025 20:37
3552ade to
fe39171
Compare
There was a problem hiding this comment.
Pull Request Overview
Implements refresh token functionality for the identity management system, refactoring the token structure and improving expiration handling.
- Introduces a Config struct to replace individual parameter passing in constructors
- Updates Token structure to use int type for ExpiresIn field and adds RefreshToken support
- Adds calculateExpiresAt helper function that implements 90% token lifespan usage to prevent expiration during requests
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ws/identity/config.go | New configuration struct for identity manager parameters |
| ws/identity/identity.go | Updated Token struct with int ExpiresIn and simplified IsExpired logic |
| ws/identity/retriever.go | Refactored token retrieval with proper response parsing and shared expiration calculation |
| ws/identity/manager.go | Updated constructors to use Config struct instead of individual parameters |
| ws/identity/manager_test.go | Updated test to use new Config-based constructor |
| cmd/rooms.go | Updated to use Config struct and removed commented code |
| cmd/login.go | Updated to use Config struct and consistent output function |
| cmd/devices.go | Updated to use Config struct |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Refresh the token a little earlier to reduce the chances of using an expired token.