fix: Spawn removal and Optimize creature checks - #866
Open
jprzimba wants to merge 2 commits into
Open
Conversation
Return immediately after removing NPCs/Monsters that can't spawn to avoid continuing logic. Rework creature-check machinery: add checkCreatureSizes, reserve bucket capacity when queuing creatures to reduce reallocations, and replace std::erase_if with a manual compacting loop in checkCreatures. The new loop skips empty buckets early, schedules delayed monster attack work as before, compacts live entries in-place (writeIndex), clears inCheckCreaturesVector for removed entries, resizes/shrinks buckets heuristically, and updates tracked sizes. Changes reduce memory churn and prevent potential use-after-processing after removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return immediately after removing NPCs/Monsters that can't spawn to avoid continuing logic. Rework creature-check machinery: add checkCreatureSizes, reserve bucket capacity when queuing creatures to reduce reallocations, and replace std::erase_if with a manual compacting loop in checkCreatures. The new loop skips empty buckets early, schedules delayed monster attack work as before, compacts live entries in-place (writeIndex), clears inCheckCreaturesVector for removed entries, resizes/shrinks buckets heuristically, and updates tracked sizes. Changes reduce memory churn and prevent potential use-after-processing after removal.