Skip to content

fix: entering text in the search input box is very laggy #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanghaikid merged 1 commit into from
Jun 19, 2025
Merged

fix: entering text in the search input box is very laggy #932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 14 additions & 36 deletions client/src/pages/databases/collections/search/Search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { useTranslation } from 'react-i18next';
import { DataService, CollectionService } from '@/http';
import Icons from '@/components/icons/Icons';
import AttuGrid from '@/components/grid/Grid';
import Filter from '@/components/advancedSearch';
import EmptyCard from '@/components/cards/EmptyCard';
import CustomButton from '@/components/customButton/CustomButton';
import { getLabelDisplayedRows } from '@/pages/search/Utils';
Expand All @@ -13,15 +12,14 @@ import SearchGlobalParams from './SearchGlobalParams';
import VectorInputBox from './SearchInputBox';
import StatusIcon, { LoadingType } from '@/components/status/StatusIcon';
import ExpandMoreIcon from '@mui/icons-material/ExpandMore';
import CustomInput from '@/components/customInput/CustomInput';
import OptimizedInput from '../data/OptimizedInput';
import PartitionsSelector from './PartitionsSelector';
import {
formatFieldType,
cloneObj,
generateVectorsByField,
saveCsvAs,
buildSearchParams,
getColumnWidth,
} from '@/utils';
import SearchParams from './SearchParams';
import DataExplorer, { formatMilvusData } from './DataExplorer';
Expand Down Expand Up @@ -527,40 +525,20 @@ const Search = (props: CollectionDataProps) => {
<SearchResults>
<Toolbar>
<div className="left">
<CustomInput
type="text"
textConfig={{
label: searchTrans('filterExpr'),
key: 'advFilter',
className: 'textarea',
onChange: onFilterChange,
value: searchParams.globalParams.filter,
disabled: explorerOpen,
variant: 'filled',
required: false,
InputLabelProps: { shrink: true },
InputProps: {
endAdornment: (
<Filter
title={''}
showTitle={false}
fields={collection.schema.scalarFields}
filterDisabled={explorerOpen}
onSubmit={(value: string) => {
onFilterChange(value);
}}
showTooltip={false}
/>
),
},
onKeyDown: (e: any) => {
if (e.key === 'Enter') {
e.preventDefault();
onSearchClicked();
}
},
<OptimizedInput
value={searchParams.globalParams.filter}
onChange={onFilterChange}
onKeyDown={(e: any) => {
if (e.key === 'Enter') {
e.preventDefault();
onSearchClicked();
}
}}
disabled={explorerOpen}
fields={collection.schema.scalarFields}
onSubmit={(expression: string) => {
onFilterChange(expression);
}}
checkValid={() => true}
/>
</div>
<div className="right">
Expand Down
Loading