-
-
Notifications
You must be signed in to change notification settings - Fork 218
feat: use build manifest to load compatible binaries #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b76dc33
feat: use build manifest to load compatible binaries
aminya c5d11f7
ci: merge build manifests in the CI
aminya 46aead4
ci: only specify the artifact patterns for packaging
aminya eef34b5
build: target ES2019 in TypeScript
aminya a3330bc
fix: sort the addon paths via a map
aminya 3f3f0d3
ci: add merge-artifacts script
aminya 55185f0
fix: rename merge-artficats.mts to merge-artifacts.mts
aminya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ | |
| }, | ||
| "homepage": "http://zeromq.github.io/zeromq.js/", | ||
| "dependencies": { | ||
| "cmake-ts": "^0.5.3", | ||
| "cmake-ts": "^0.6.0", | ||
| "node-addon-api": "^8.3.0" | ||
| }, | ||
| "devDependencies": { | ||
|
|
@@ -67,9 +67,9 @@ | |
| "which": "^5.0.0" | ||
| }, | ||
| "engines": { | ||
| "node": ">= 12", | ||
| "pnpm": ">= 9" | ||
| "node": ">= 12" | ||
| }, | ||
| "packageManager": "[email protected]", | ||
| "overrides": { | ||
| "typescript": "~4.9.5", | ||
| "node-gyp": "10.0.1" | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.