Skip to content

Remove macOS Socket.Select workaround that caused Cleanup() to hang #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
follesoe wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −18
Open

Remove macOS Socket.Select workaround that caused Cleanup() to hang #1142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions src/NetMQ/Core/Utils/Poller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ You should have received a copy of the GNU Lesser General Public License
using System.Collections.Generic;
using System.Linq;
using System.Net.Sockets;
#if !NETFRAMEWORK
using System.Runtime.InteropServices;
#endif
using System.Threading;

namespace NetMQ.Core.Utils
Expand Down Expand Up @@ -281,22 +278,7 @@ private void Loop()
try
{
timeout = timeout != 0 ? timeout * 1000 : -1;
#if NETFRAMEWORK
Socket.Select(readList, null, errorList, timeout);
#else
if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
{
// Socket.Select does not work properly on macOS .NET Core when readList and errorList are passed
// together. To avoid this problem, we call the Select function separately for errorList.
// Please refer to this issue: https://github.com/dotnet/corefx/issues/39617
SocketUtility.Select(readList, null, null, timeout);
SocketUtility.Select(null, null, errorList, timeout);
}
else
{
Socket.Select(readList, null, errorList, timeout);
}
#endif
}
Comment on lines 280 to 282
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes a macOS-specific hang, but the repo’s CI doesn’t run tests on macOS, and there’s no regression test that would fail if Socket.Select blocks forever in the poll loop. Consider adding a regression test that exercises Cleanup(block: false) under the same conditions as #1040 and asserts it completes within a bounded time (and/or add a macOS CI job so the test actually runs on the affected platform).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

@drewnoakes drewnoakes Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1148

catch (SocketException)
{
Expand Down
Loading