Skip to content

fix: code blocks with titles and line numbers have wrong rounded borders (#166) #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
squidfunk merged 1 commit into from
Jun 24, 2026
Merged

fix: code blocks with titles and line numbers have wrong rounded borders (#166) #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...stylesheets/classic/main.82a87433.min.css → ...stylesheets/classic/main.65161b11.min.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .../stylesheets/modern/main.19d3147f.min.css → .../stylesheets/modern/main.bddce058.min.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@
{% endblock %}
{% block styles %}
{% if config.theme.variant == "modern" %}
{% set href = 'assets/stylesheets/modern/main.19d3147f.min.css' | url %}
{% set href = 'assets/stylesheets/modern/main.bddce058.min.css' | url %}
{% else %}
{% set href = 'assets/stylesheets/classic/main.82a87433.min.css' | url %}
{% set href = 'assets/stylesheets/classic/main.65161b11.min.css' | url %}
{% endif %}
<link rel="stylesheet" href="{{ href }}">
{% if config.theme.palette %}
Expand Down
32 changes: 17 additions & 15 deletions src/assets/stylesheets/classic/main/extensions/pymdownx/_highlight.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@

// Code block
.highlight {

// .o = Operator
// .ow = Operator, word
:is(.o, .ow) {
color: var(--md-code-hl-operator-color);
}

.p { // Punctuation
.p {
// Punctuation
color: var(--md-code-hl-punctuation-color);
}

Expand Down Expand Up @@ -151,11 +151,13 @@
border-radius: px2rem(2px);
}

.gd { // Diff, delete
.gd {
// Diff, delete
background-color: var(--md-typeset-del-color);
}

.gi { // Diff, insert
.gi {
// Diff, insert
background-color: var(--md-typeset-ins-color);
}

Expand Down Expand Up @@ -287,10 +289,15 @@
font-size: px2em(13.6px);
user-select: none;
background-color: var(--md-code-bg-color);
border-top-left-radius: px2rem(2px);
border-bottom-left-radius: px2rem(2px);
}

// Only apply the top left border radius to the first line number - if it's
// not the first row, a title was set which is already rounded
tr:first-child > .linenos {
border-top-left-radius: px2rem(2px);
}

// Code block line numbers container
.linenodiv {
box-shadow: px2rem(-1px) 0 var(--md-default-fg-color--lightest) inset;
Expand All @@ -305,14 +312,6 @@
span[class] {
padding-right: px2em(8px, 13.6px);
}

// .active {
// display: inline-block;
// background-color: var(--md-code-hl-color--light);
// margin-left: -1.1764705882em; // @todo source correct values
// padding-left: 1.1764705882em;
// font-weight: bold;
// }
}

// Code block container - stretch to remaining space
Expand All @@ -331,7 +330,6 @@

// Scoped in typesetted content to match specificity of regular content
.md-typeset {

// Code block with line numbers - unfortunately, these selectors need to be
// overly specific so they don't bleed into code blocks in annotations.
.highlighttable {
Expand All @@ -343,6 +341,11 @@
border-top-left-radius: 0;
border-bottom-left-radius: 0;
}

// Remove rounded border if title is present
> tbody > tr:nth-child(2) > .code > div > pre > code {
border-top-right-radius: 0;
}
}

// Code block result container
Expand Down Expand Up @@ -370,7 +373,6 @@

// [mobile -]: Align with body copy
@include break-to-device(mobile) {

// Top-level code block
.md-content__inner > .highlight {
margin: 1em px2rem(-16px);
Expand Down
19 changes: 10 additions & 9 deletions src/assets/stylesheets/modern/main/extensions/pymdownx/_highlight.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,10 +289,14 @@
font-size: px2em(13.6px);
user-select: none;
background-color: var(--md-code-bg-color);
border-top-left-radius: px2rem(8px);
border-bottom-left-radius: px2rem(8px);
}

// Add rounded border if no title is present
tr:first-child > .linenos {
border-top-left-radius: px2rem(8px);
}

// Code block line numbers container
.linenodiv {
box-shadow: px2rem(-1px) 0 var(--md-default-fg-color--lightest) inset;
Expand All @@ -307,14 +311,6 @@
span[class] {
padding-right: px2em(8px, 13.6px);
}

// .active {
// display: inline-block;
// background-color: var(--md-code-hl-color--light);
// margin-left: -1.1764705882em; // @todo source correct values
// padding-left: 1.1764705882em;
// font-weight: bold;
// }
}

// Code block container - stretch to remaining space
Expand Down Expand Up @@ -345,6 +341,11 @@
border-top-left-radius: 0;
border-bottom-left-radius: 0;
}

// Remove rounded border if title is present
> tbody > tr:nth-child(2) > .code > div > pre > code {
border-top-right-radius: 0;
}
}

// Code block result container
Expand Down