feat: command-free build#291
Merged
Merged
Conversation
1901cc8 to
9fed5bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zed currently has a macOS spawn bug bare executables are resolved before
Command::envsis applied. SoCommand::new("ruby")can pick Ruby from Zed’s own processPATH, even though the child process receives the right projectPATH.That breaks Ruby language servers in projects using mise, direnv, asdf, or rbenv. The server can start under the wrong Ruby, with the wrong gems.
Resolving Ruby to an absolute path inside the extension is not a good fix. Those paths are dynamic and do not fit the extension manifest
process:execcapability model.This PR avoids the broken Command API path for language server startup by making the default build command-free (previous behavior).
Command-free launch order:
lsp.<server>.binary.path, if configured.use_bundleris true, runbundle exec <server>.<server>withworktree.which.use_bundlerdefaultsuse_bundlerruby-lsptruerubocoptruesolargraphtruesrbtruesteeptruefuzzykanayagofalseherbtrueKanayago defaults to
falsebecausebundle exec kanayagofails when the gem is not in the project bundle. Once that process is launched, the extension cannot fall back to a direct executable.