Validate distinct Projects and Ecosystem navigation - #18
Merged
Conversation
Structural validator checks: internal Projects link targets /projects/, shared disclosure trigger labeled Ecosystem (old Projects trigger rejected), 8 registry links server-rendered, and the Fusion System Blocks page keeps Public Beta. Step 1 Mermaid assertions unchanged. Co-Authored-By: Claude Fable 5 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Step 2 validation coverage to ensure the portfolio’s navigation distinguishes the internal Projects page from the shared Ecosystem disclosure, and documents the expected validation outcomes for this step.
Changes:
- Introduces new structural checks in
scripts/validate-build.jsfor/projects/link targeting, Ecosystem trigger labeling, and minimum server-rendered disclosure links. - Adds a regression check that
/projects/fusion-system-blocks/continues to display “Public Beta”. - Documents Step 2 validation expectations and results in a new markdown note.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| STEP_2_PORTFOLIO_ECOSYSTEM_VALIDATION.md | Documents Step 2 navigation/validator expectations and observed outcomes. |
| scripts/validate-build.js | Extends post-build validator with Step 2 navigation and Fusion page assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
141
to
+144
| const discStart = indexHtml.indexOf('id="zc-project-disclosure"'); | ||
| const discEnd = indexHtml.indexOf('id="zc-mobile-drawer"'); | ||
| const discBody = discStart !== -1 && discEnd > discStart ? indexHtml.slice(discStart, discEnd) : ''; | ||
| check('disclosure links server-rendered', (discBody.match(/href="/g) || []).length >= 3); | ||
| check('disclosure links server-rendered', (discBody.match(/href="/g) || []).length >= 8, `found ${(discBody.match(/href="/g) || []).length}`); |
Comment on lines
+151
to
+154
| const ecoTriggerMatch = indexHtml.match(/<button[^>]*aria-controls="zc-project-disclosure"[^>]*>([\s\S]*?)<\/button>/); | ||
| const ecoTriggerText = (ecoTriggerMatch?.[1] || '').replace(/<[^>]+>/g, '').trim(); | ||
| check('ecosystem disclosure trigger labeled Ecosystem', ecoTriggerText.startsWith('Ecosystem'), `got "${ecoTriggerText}"`); | ||
| check('old shared Projects trigger absent', !ecoTriggerText.startsWith('Projects')); |
Comment on lines
+157
to
+158
| const fsbPage = fs.readFileSync(path.join(build, 'projects', 'fusion-system-blocks', 'index.html'), 'utf8'); | ||
| check('Fusion System Blocks page shows Public Beta', fsbPage.includes('Public Beta')); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structural validator checks: internal Projects link targets /projects/, shared disclosure trigger labeled Ecosystem (old Projects trigger rejected), 8 registry links server-rendered, and the Fusion System Blocks page keeps Public Beta. Step 1 Mermaid assertions unchanged.