fix(profile+notifications): banner upload crop, notification bell All tab, read-state styling#451
Merged
Merged
Conversation
The profile editor sent both avatar and banner images to nostr.build's /api/v2/upload/profile endpoint, which crops to a square profile picture. The NIP-96 media_type='banner' hint isn't honored there (the endpoint's advertised transformations don't include avatar/banner cropping), so banners came out pfp-shaped. Route banner uploads through the general /api/v2/upload/files endpoint (the same one the composer uses), which preserves the uploaded aspect ratio. Avatars stay on /upload/profile where a square crop is correct. The NIP-98 auth 'u' tag and response parsing already key off the same url variable, so both paths stay consistent.
…h unread highlight DMs were merged into the bell's All tab, making the notifications page appear blank when the only activity was DMs. All tab now shows only Nostr notifications (matching the full page scope); DMs remain in the DMs tab. Replaces the 55% opacity dim on read rows with a subtle orange tint on unread rows — same treatment as the bell dropdown — so the full notifications list renders at full legibility.
…tandalone ones The parser classifies kind 1 events with e-tags as 'comment' (threaded reply) and those without as 'mention' (standalone note). Most real-world mentions happen inside reply threads, so the Mentions tab was always empty despite activity. Mentions tab now shows both types — any note that p-tagged you — matching how other Nostr clients define a mention.
ParsedBio: add white-space: pre-wrap so \n in bio text renders as line breaks instead of collapsing to a wall of text. ProfileEditModal: bump banner negative margin from -mx-2 to -mx-4 to match the modal's px-4 mobile padding, so the banner fills the full width instead of leaving gaps on each side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProfileEditModalno longer forces a square crop when uploading a banner image; the full aspect ratio is preserved-mx-2to-mx-4to match the modal'spx-4mobile padding, so it fills edge-to-edge on small screensParsedBionow renders\ncharacters as actual line breaks (white-space: pre-wrap) instead of collapsing bios into a wall of text/notificationsdisplays — DMs remain in the dedicated DMs tabTest plan
/notificationsshould also be empty (no false "broken" impression)/notifications, unread rows should have a faint orange background tint; read rows should display at full opacity with no tint🤖 Generated with Claude Code