fix(logo): white lightning bolt in dark-mode logo and loader#449
Merged
Conversation
In dark mode the lightning bolt read as a dark cutout (it showed the page background through a hole in the orange lens) on the logo, and as a solid black shape on the loading animation — both low-contrast on dark backgrounds. - zap_cooking_logo_white.svg: add a white bolt path over the lens so the bolt is explicitly white instead of a transparent cutout. - pan-animated-dark.svg: change the bolt (Vector_5) fill from black to white (animation and the ring are unchanged). The QR center (pan-qr-center.svg) and favicon already render a white bolt, so they're untouched.
# Conflicts: # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In dark mode the Zap Cooking lightning bolt rendered with poor contrast:
zap_cooking_logo_white.svg): the bolt was a transparent cutout in the orange lens, so it showed the dark page background through it — reading as a dark/invisible bolt on dark surfaces.pan-animated-dark.svg): the bolt was a solid black shape.This makes the bolt explicitly white in both, matching the favicon and the QR-code center logo (which already use a white bolt).
Changes
static/zap_cooking_logo_white.svg— add a white bolt path over the gradient lens so the bolt is filled white instead of being a see-through cutout.static/pan-animated-dark.svg— change the bolt (Vector_5) fill fromblacktowhite. The morph animation and the surrounding ring are unchanged.Not touched (already correct or out of scope):
pan-qr-center.svgandfavicon.svg— already render a white bolt.zap_cooking_logo_black.svg/pan-animated-light.svg— light-mode variants.Verification
Rendered both SVGs on the dark-mode background (
#1f2937) and confirmed the bolt is now white in each.Logo Example