Allow configuring the specification version#220
Merged
Conversation
And bump the default version from 8.2 to 9.2.
pquentin
changed the title
ywangd
reviewed
Jan 22, 2026
| if os.path.exists(schema_filepath): | ||
| raise RuntimeError(f'schema file already exists [{schema_filepath}]. Please remove it before download.') | ||
| git_branch = options.get('version', '8.12') | ||
| git_branch = self.options['version'] |
Owner
There was a problem hiding this comment.
I missed this before merging. To support specifying version for the download function, we need to consult with the options variable passed-in and fallback to self.options for default. I pushed 0fed0b8 to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And bump the default version from 8.2 to 9.2.