feat(navigation): add list top/bottom jump shortcuts and select all toggle - #1616
feat(navigation): add list top/bottom jump shortcuts and select all toggle#1616ashvin-to wants to merge 3 commits into
Conversation
📝 WalkthroughWalkthroughThe change adds Home and End navigation for focused panels, mouse-based focus and file interaction, toggleable file selection, and supporting tests. It also propagates mouse commands through ChangesNavigation and interaction
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Mouse
participant Update
participant MouseHandler
participant PanelModel
Mouse->>Update: left-click coordinates
Update->>MouseHandler: handle mouse message
MouseHandler->>PanelModel: resolve focus and update cursor
PanelModel-->>MouseHandler: updated panel state
MouseHandler-->>Update: command
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/internal/ui/filepanel/update.go`:
- Around line 84-90: Update SelectAllItem to determine whether all items in the
current m.element collection are selected by checking each item.Location
individually, rather than comparing SelectedCount() with len(m.element). Toggle
by resetting selections when every current item is selected; otherwise select
the current items, while preserving selections outside the current directory.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4218ba3a-c5f5-4b88-8267-a9194bce5997
📒 Files selected for processing (15)
.gitignoresrc/internal/common/config_type.gosrc/internal/key_function.gosrc/internal/model.gosrc/internal/mouse_function.gosrc/internal/mouse_function_test.gosrc/internal/ui/filemodel/navigation.gosrc/internal/ui/filepanel/navigation.gosrc/internal/ui/filepanel/navigation_test.gosrc/internal/ui/filepanel/update.gosrc/internal/ui/filepanel/utils.gosrc/internal/ui/metadata/model.gosrc/internal/ui/processbar/model_navigation.gosrc/internal/ui/sidebar/navigation.gosrc/superfile_config/hotkeys.toml
Description
This PR adds keyboard shortcuts for:
Atoggles selecting all items if not all are selected, or deselecting all items if all are currently selected.Related Issues
Fixes #1614
Partially addresses #300
✅ Pre-Submission Checklist
go fmt ./...to format the codegolangci-lint runand fixed any reported issuesSummary by CodeRabbit
New Features
Bug Fixes
Tests