feat(config): add open_file_with_default_app option - #1613
Open
Longchuanzheng wants to merge 2 commits into
Open
feat(config): add open_file_with_default_app option#1613Longchuanzheng wants to merge 2 commits into
Longchuanzheng wants to merge 2 commits into
Conversation
Add a new boolean config `open_file_with_default_app` (default: true) that controls whether pressing confirm (Enter/right/l) on a file launches the system default application (open/xdg-open/rundll32). Set to false to disable launching external programs — the file is just selected and its preview shown. Directories are still entered, and the chooser mode is unaffected. Co-Authored-By: Claude Opus 4.7 <[email protected]>
Contributor
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdds ChangesDefault application file opening
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/internal/handle_panel_movement.go`:
- Around line 67-71: Ensure executeOpenCommand enforces
common.Config.OpenFileWithDefaultApp before invoking the system opener,
returning without launching an external program when disabled. Keep the existing
enterPanel behavior intact and apply the guard at the command execution boundary
for all callers.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 20c61bfe-47e4-4057-9603-fef4d1a7e214
📒 Files selected for processing (3)
src/internal/common/config_type.gosrc/internal/handle_panel_movement.gosrc/superfile_config/config.toml
Move the OpenFileWithDefaultApp check from enterPanel into executeOpenCommand so the guard applies at the system-opener execution boundary for all callers, not just confirm-on-file. enterPanel behavior is unchanged. Co-Authored-By: Claude Opus 4.7 <[email protected]>
Author
|
@coderabbitai help |
Contributor
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
Author
|
@coderabbitai review |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new boolean config
open_file_with_default_app(default: true) that controls whether pressing confirm (Enter/right/l) on a file launches the system default application (open/xdg-open/rundll32).Set to false to disable launching external programs — the file is just selected and its preview shown. Directories are still entered, and the chooser mode is unaffected.
Summary by CodeRabbit