Fixed the links for FOG, [Cold], Love you and Okuri to take to the right pages#264
Merged
Merged
Conversation
… know where else to put GBS)
Mimigris
reviewed
Jun 7, 2026
| "mapLocations": { | ||
| "0002": "Home", | ||
| "0003": "Choice", | ||
| "0003": { "title": "Choice", "urlTitle": "Snowy Nexus" }, |
Contributor
There was a problem hiding this comment.
Instead of using spaces in urlTitle, please use an underscore for consistency with existing configurations.
Mimigris
reviewed
Jun 7, 2026
| "0134": { "title": "Trash Can", "urlTitle": "Study" }, | ||
| "0135": { "title": "Trash Can", "urlTitle": "Study" }, | ||
| "0136": { "title": "Trash Can", "urlTitle": "Study" }, | ||
| "0137": { "title": "Trash Can", "urlTitle": "Study" } |
Contributor
There was a problem hiding this comment.
For Ruin, Trash Can and Classroom, since those need to use an urlTitle at least thrice while always leading to the same page, it would be better to use locationUrlTitles instead of replacing every sentence (if you don't know yet how it works, you can look at the Yume Nikki config as reference).
Contributor
|
Outside of the aforementioned points, the config update seems good for FOG and [COLD]; since Love You and Okuri do not have yet wiki pages, I do not think it is really needed to add them now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel the least confident in Love you since I know that game the least.
I didn't know where else to put Good-Bye Stranger from FOG so I put it in Leon's Bedroom.
Other than that I hope this is ok.