Region preview + 16:9 landscape layout (v1.1.0)#25
Merged
Conversation
The macOS region-select overlay used native fullscreen, which insets the content area by the menu bar (innerHeight 1073 vs the 1107 captured screenshot). Stretching the full-screen screenshot into the shorter window made the selection look zoomed and land lower than drawn. - Cover the full display on macOS via explicit bounds at the screen-saver window level instead of native fullscreen, so the overlay maps 1:1 to the screenshot. Windows/Linux keep fullscreen. - Map selection coordinates using the screenshot's actual dimensions rather than assuming devicePixelRatio, keeping selection correct regardless of window sizing. - Surface desktopCapturer failures (e.g. missing macOS Screen Recording permission) with a dialog that links to System Settings, instead of failing silently.
Show a cropped screenshot preview of the watched region instead of the red coordinate box, persisting it as regionPreview in config. Reflow the UI into a fixed 16:9 desktop window: a collapsible Telegram settings strip (auto-collapses once token + chat ID are set) over a two-column body with the region preview and Start/Stop on the left, and Interval/Threshold plus Status/log on the right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
regionPreviewin config.Verification
Verified the rendered UI via Electron
capturePage: collapsed/expanded settings states fit the fixed 16:9 box with no overflow or overlap; region crop/resize produces a valid preview.