Add in-app update notifier#23
Merged
Merged
Conversation
Checks GitHub Releases once on launch (main process, no deps) and shows a dismissible banner when a newer version exists; the Update button opens the releases page in the browser. Works on all platforms, unsigned. Adds unit tests for the version comparison.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the chosen "in-app update notifier" approach.
How it works
releases/latestfrom the GitHub API (Nodehttps, no new deps, sidesteps the renderer CSP) and compares the tag toapp.getVersion().shell.openExternal.Verified
app.getVersion()reads package.json version in production (the dev script-launch returning the Electron version is a launch artifact only).Note: this only helps users from the next release onward — people on 1.0.2 don't have the checker yet.