Skip to content

Remove unnecessary awaits from sync functions - #103

Open
mattcphillips wants to merge 1 commit into
masterfrom
chore/removeUnnecessaryAwaits
Open

Remove unnecessary awaits from sync functions#103
mattcphillips wants to merge 1 commit into
masterfrom
chore/removeUnnecessaryAwaits

Conversation

@mattcphillips

Copy link
Copy Markdown
Contributor

Description

  • Remove awaits from synchronous functions.

Related Issue

Motivation and Context

  • It's a negligible performance optimization, but awaiting sync functions can be misleading

Types of changes

  • Documentation only (no changes to either lib/ or test/ files)
  • Bug fix (non-breaking change which fixes an issue. you didn't modify existing tests)
  • New feature (non-breaking change which adds functionality. you added at least one new test)
  • Breaking change (fix or feature that would cause existing functionality to change. you had to modify existing tests.)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the Hapi.js style guide.
  • I have updated the documentation as needed.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mattcphillips mattcphillips changed the title Remove unnecessary waits from sync functions Remove unnecessary awaits from sync functions Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant