Xnor dev - #3
Closed
gavrackerss wants to merge 77 commits into
Closed
Conversation
Author
|
Made in error. |
dirkpetersen
added a commit
to dirkpetersen/pnw-pilot
that referenced
this pull request
Jun 22, 2026
… 3 fixes applied) Adds operator(carrier)+bars+dBm(RSSI/RSRP/RSRQ/SNR) logging via mmcli, emitted to qlog only on change -> a timeline of where LTE was slow. Verified live earlier: lte rssi=-67 rsrp=-97 snr=16.4, operator=Verizon. Gemini review (advisor) raised 5 points; I judged 3 valid and fixed them, 2 already-safe: - xnor-tech#1 CRITICAL (4 sequential 15s-timeout mmcli calls per tick could stall WiFi recovery ~60s): FIXED -> signal block now runs every SIGNAL_EVERY_N=3 ticks (~60s), not every 20s loop, so it can't repeatedly delay the arbitration/recovery logic that runs earlier in the loop. - xnor-tech#2 HIGH (_signal_setup_done_for set even on --signal-setup failure -> never retries -> zero logs): FIXED -> mark done ONLY on returncode 0, so a failed setup during boot/attach is retried. - xnor-tech#3 HIGH (bars boundary jitter spams qlog): FIXED -> removed the standalone bars-flip trigger; change-detection now gates on >=2 dBm move, giving bars hysteresis for free. - commaai#4 exception isolation, commaai#5 logs-when-TetheringEnabled=0: confirmed already safe/intended. parses + ruff clean. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
dirkpetersen
added a commit
to dirkpetersen/pnw-pilot
that referenced
this pull request
Jun 22, 2026
…uard (Gemini-reviewed, 3 fixes)
Generalizes single-home -> a LIST of {label,ssid,lat,lon,portal} (new param
TetheringPriorityNetworks). Adds priority_networks.py (parse/migrate/select), geo_gate.near_any_home,
multi-network daemon selection + per-entry GPS auto-learn with flash-wear guard (write only when
moved >50m), and Add/list/remove settings UI. Legacy single-home params migrate transparently.
Gemini review (advisor) found 3 real bugs (all VERIFIED against the code, all FIXED):
- xnor-tech#1 CRITICAL: chosen_ssid='' when scan stale -> decide() tears down ACTIVE client WiFi to raise the
hotspot (connection flap). FIXED -> STICKY ACTIVE CONNECTION: if already on one of our priority
SSIDs, seed it into scan+chosen so decide() returns noop and never drops a working link.
- xnor-tech#2 CRITICAL: ConfirmDialog(..., needs_reject=False) -> this v0.11.2 fork's ConfirmDialog has no
such kwarg -> TypeError/UI crash. FIXED -> removed the invalid kwarg (OK-only dialog = no cancel).
- xnor-tech#3 MODERATE: deleting the last network ([]) re-triggered legacy migration -> zombie resurrection,
un-removable. FIXED -> parse() migrates ONLY when the param was never a valid list; an explicit []
is authoritative. Added 2 tests (empty-list-respected, migration-still-runs-when-unset). 20 pass.
- Gemini confirmed stranding (escape hatch), flash-wear guard, and typed-Params handling already safe.
parses + ruff clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.