fix(chat): send bounded ACP image attachments#369
Open
keh4l wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageContent/api/acp_promptto a 32 MiB request-body limit so a 20 MB image can survive base64/JSON expansion without widening adjacent APIsAddresses #358.
Verification
pnpm eslint .pnpm test— 211 files, 2608 tests passedpnpm build— 32 static pages generatedcargo check --no-default-features --bin codeg-servercargo test --no-default-features --bin codeg-server --lib— 1638 passed, 1 ignoredcargo clippy --no-default-features --bin codeg-server --lib -- -D warningscargo check --no-default-features --bin codeg-mcpcargo clippy --no-default-features --bin codeg-mcp -- -D warningsNotes
cargo checkis not reported because this host lacks the GTK/GLib development packages required byglib-sys.cargo fmt --checkalready fails on upstreammain; this PR introduces no additional failing file compared with that baseline.ImageContentlocated outside the session worktree.