Skip to content

Improve pruning handler test with error checks #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverboehm-xgr merged 1 commit into from
May 15, 2026
Merged

Improve pruning handler test with error checks #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions txpool/txpool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,26 +531,27 @@ func TestAddTxHighPressure(t *testing.T) {
t.Run(
"pruning handler is signaled",
func(t *testing.T) {
t.Parallel()
require.NoError(t, err)
t.Cleanup(pool.Close)

pool, err := newTestPool()
assert.NoError(t, err)
pool.SetSigner(&mockSigner{})

// signalPruning uses a non-blocking send. Use a buffered channel here
// so the test observes the signal deterministically without relying
// on goroutine scheduling.
pool.pruneCh = make(chan struct{}, 1)
// mock high pressure
slots := 1 + (highPressureMark*pool.gauge.max)/100
pool.gauge.increase(slots)

// enqueue tx
go func() {
assert.NoError(t,
pool.addTx(local, newTx(addr1, 0, 1)),
)
}()
require.NoError(t, pool.addTx(local, newTx(addr1, 0, 1)))

// pick up signal
_, ok := <-pool.pruneCh
assert.True(t, ok)
select {
case _, ok := <-pool.pruneCh:
require.True(t, ok)
case <-time.After(5 * time.Second):
t.Fatal("timed out waiting for pruning signal")
},
)

Expand Down
Loading