Skip to content

Fix crash on renderbuffers with no sampler filter (#674) #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chaos02 wants to merge 1 commit into
base: dev
Choose a base branch
from
+8 −0
Open

Fix crash on renderbuffers with no sampler filter (#674) #870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/net/vulkanmod/gl/VkGlRenderbuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,14 @@ void allocateImage(int width, int height, int vkFormat) {
}

void updateSampler() {
// A renderbuffer is a render target, not a sampled resource, so it may
// legitimately have no sampler filter set (minFilter == 0, the unset
// default). Treat that as "no sampler needed" and skip the sampler
// build instead of falling through to the "Unexpected min filter value"
// throw below. See issue #674 (Xaero's custom depth renderbuffer FBO).
if (minFilter == 0)
return;

if (vulkanImage == null)
return;

Expand Down