Skip to content

Add query parameter locale to Wowhead Tooltip url#1280

Open
htve wants to merge 6 commits into
wowsims:masterfrom
htve:add-locale-to-wowhead-tooltip-url
Open

Add query parameter locale to Wowhead Tooltip url#1280
htve wants to merge 6 commits into
wowsims:masterfrom
htve:add-locale-to-wowhead-tooltip-url

Conversation

@htve

@htve htve commented Jan 6, 2026

Copy link
Copy Markdown

It allows the tooltip to display the correct localization data

Comment thread ui/i18n/locale_service.ts Outdated
Comment thread ui/i18n/wowhead_locale_service.ts Outdated
Comment thread ui/i18n/wowhead_locale_service.ts Outdated
@1337LutZ

1337LutZ commented Jan 6, 2026

Copy link
Copy Markdown

@htve We have params.set('domain', ${langPrefix}mop-classic); in wowhead.ts already btw. What does adding the locale do differently? (just thought about it)

@htve

This comment was marked as abuse.

@1337LutZ

1337LutZ commented Jan 6, 2026

Copy link
Copy Markdown

@htve We have params.set('domain', ${langPrefix}mop-classic); in wowhead.ts already btw. What does adding the locale do differently? (just thought about it)

He resolved missing locale parameters in ui/core/proto_utils/database.ts:403.

Ahhh I see! Yea getting the raw tooltip URL is missing it indeed

@htve

This comment was marked as abuse.

@1337LutZ

1337LutZ commented Jan 7, 2026

Copy link
Copy Markdown

@dodoels can you do a final check on this as you added the i18n feature initially 🙏

Comment thread ui/i18n/locale_service.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants