Zook : Parameter Selection #257
Conversation
|
@ocdbytes Can you please resolve the merge conflicts on this PR? I'm reviewing it and we are planning to merge it by this week. |
Resolve conflicts with the buffer abstraction while preserving parameter-selection protocol semantics.
|
Hey @shreyas-londhe, this branch did not have any conflicts with main before merging buffer abstraction. I opened a PR to this branch here ocdbytes#11, which adds buffer abstraction. Merging it will make this branch conflict free again. cc @ocdbytes |
Resolve conflicts with buffer abstraction
|
Thanks @zkfriendly I have merged your PR now there are no conflicts. I skimmed through the changes will go through them properly tomorrow to see if there is anything to be changed. |
Merging this PR will not alter performance
Comparing Footnotes
|
| #[derive(Clone, Debug)] | ||
| pub struct ProtocolConfig<M: Embedding> { | ||
| security: SecuritySpec, | ||
| tuning: TuningSpec, | ||
| rounds: Vec<RoundConfig<M>>, | ||
| basecase: BasecasePlan<M::Target>, | ||
| } |
There was a problem hiding this comment.
Can ProtocolConfig derive Serialize/Deserialize? It's #[derive(Clone, Debug)] today, so nothing downstream can embed it in a serialized scheme.
Context for why I'm asking: ProveKit builds its Fiat-Shamir domain separator by serializing the whole scheme (WHIR config included) and hashing that. whir::Config already handles it, with Serialize/Deserialize and #[serde(bound = "")] for the embedding generic. Once this stack has a prover/verifier runtime and replaces whir::Config as what schemes carry, ProtocolConfig will need the same.
It's not a one-liner though. RoundConfig, RoundMode, MaskOracleConfig, BasecasePlan in this file, plus Solved and CodeSwitchConfig, all need it too, and none of them derive it yet (SecuritySpec and TuningSpec already do). The embedding-generic ones want #[serde(bound = "")] like whir::Config.
There was a problem hiding this comment.
Hey @BornPsych
I have added these derives in wiring PR (next PR). Ig missed it here in this PR
Changes :
Tests :
This PR was squashed from 47 commits during conflict resolution against PR #251 (merged to
main)Commit history maintained in personal fork.