WPB-26823: make meetings cleanup fully index-driven#5328
Open
blackheaven wants to merge 7 commits into
Open
Conversation
Add two partial indexes and rewrite the meetings cleanup query so the background worker stays fully index-driven as the meetings table grows: - idx_meetings_recurrence_eff_end on GREATEST(end_time, recurrence_until) for bounded recurring meetings (recurring branches of list/cleanup queries). - idx_meetings_end_time_nonrecurring on end_time for non-recurring meetings, so cleanup skips not-yet-expired recurring rows whose original slot is long past. Rewrite getOldMeetingsImpl to issue one bounded, index-backed query per meeting kind (non-recurring vs bounded recurring) and merge the batches in Haskell, mirroring the in-memory store. (hasql-th rejects UNION ALL in a FROM derived table, so the two statements are issued separately and merged.) Both indexes are built CONCURRENTLY and registered in nonTransactionMigrations. EXPLAIN ANALYZE on an adversarial data set (75k not-yet-expired recurring rows with the oldest end_time, few expired rows) drops from 1661 buffers / 11.6ms / 75086 rows filtered to 9 buffers / 0.2ms / 0 filtered. Follow-up to #5309 (discussion r3518905163).
zebot
added
the
ok-to-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-26823
Checklist
changelog.d