spar-integration: retry transient 5xx on client delete in re-auth test#5314
Draft
blackheaven wants to merge 2 commits into
Draft
spar-integration: retry transient 5xx on client delete in re-auth test#5314blackheaven wants to merge 2 commits into
blackheaven wants to merge 2 commits into
Conversation
The "password user that was upgraded to SCIM has to provide password" test hit an intermittent brig 500 on DELETE /clients/:cid (an opaque transient, likely a backend read under load). Reuse the existing retryNUntil helper (Control.Retry) to retry the idempotent delete on transient 5xx, then assert the expected status -- so a transient 500 no longer fails the test, while genuine failures still surface.
zebot
added
the
ok-to-test
akshaymankar
reviewed
Jul 7, 2026
| payload = | ||
| RequestBodyLBS . encode . object . maybeToList $ | ||
| fmap ("password" .=) pw | ||
| transientStatuses = [500, 502, 503, 504] |
Member
There was a problem hiding this comment.
I think we shouldn't retry here, but find out why brig is failing with 5xx and fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d