Skip to content

[codex] add territory judgement overlay#24

Merged
wimi321 merged 10 commits into
mainfrom
codex/territory-judgement-qa
Jul 7, 2026
Merged

[codex] add territory judgement overlay#24
wimi321 merged 10 commits into
mainfrom
codex/territory-judgement-qa

Conversation

@wimi321

@wimi321 wimi321 commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Summary

Adds a KaTrain-inspired territory judgement mode to GoAgent so users can inspect ownership/territory directly on the board instead of only reading numeric KataGo output.

What Changed

  • Preserves KataGo rootInfo.ownership and ownershipStdev in KataGoMoveAnalysis.
  • Adds a reusable territory judgement model that converts ownership into black/white/unclear cells, region summaries, confidence, and lead text.
  • Adds a premium board overlay with three display modes: heat, blocks, and marks.
  • Adds a compact 形势判断 control with deepen action and a timeline summary chip.
  • Wires territory judgement into the workbench and UI Gallery with localized labels.
  • Adds contract tests for ownership parsing, board overlay wiring, workbench controls, and UI Gallery samples.
  • Includes the already validated mouse-wheel replay contract for the winrate timeline.

User QA

Flow under test: UI Gallery -> switch territory display modes -> board overlay and timeline summary update without layout breakage.

Findings fixed during QA:

  • On narrow viewports, the UI Gallery candidate tooltip overlapped the territory controls. Fixed by repositioning the tooltip below the board on small screens.
  • On narrow viewports, the territory control could visually crowd the deepen button. Fixed by using compact spacing and hiding the confidence chip under small widths.
  • Timeline territory summary initially rendered as a tall multi-row block. Fixed by adding a compact one-line summary chip for timeline placement.

Verification

  • pnpm install --frozen-lockfile
  • pnpm check
  • pnpm check:teacher-quality
  • Browser UI QA on http://127.0.0.1:4177/index.html?ui-gallery=1
    • Page identity verified.
    • Not blank.
    • No framework overlay.
    • Console errors/warnings: none relevant.
    • Heat / blocks / marks controls clicked and state verified.
    • Desktop screenshot captured.
    • 390x844 viewport screenshot captured after responsive fixes.

Notes

  • No release artifacts, installer files, API keys, tokens, or website/design-concepts/ files are included.
  • This PR does not change release versioning.

@wimi321 wimi321 marked this pull request as ready for review July 7, 2026 16:38
@wimi321 wimi321 merged commit 23e96be into main Jul 7, 2026
8 checks passed
@wimi321 wimi321 deleted the codex/territory-judgement-qa branch July 7, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant