feat: add --lookup-resources flag for offline lookup in render/lint commands#657
Open
dmmordvi wants to merge 10 commits into
Open
feat: add --lookup-resources flag for offline lookup in render/lint commands#657dmmordvi wants to merge 10 commits into
dmmordvi wants to merge 10 commits into
Conversation
…lint Signed-off-by: Dmitry Mordvinov <[email protected]>
Signed-off-by: Dmitry Mordvinov <[email protected]>
Signed-off-by: Dmitry Mordvinov <[email protected]>
Signed-off-by: Dmitry Mordvinov <[email protected]>
…lDecoder Signed-off-by: Dmitry Mordvinov <[email protected]>
An offline lookup <apiVersion> <Kind> <ns> "" (list form) for a kind absent from --lookup-resources panicked inside the fake dynamic client with "you must register resource to list kind", failing the render. This contradicted the offline stub promise that an absent kind yields an empty result. Wrap the fake resource interface so a LIST that hits the unregistered list-kind panic recovers and returns an empty UnstructuredList instead. GET-of-missing and LIST-of-provided-kind behavior are unchanged.
A --lookup-resources file containing a kind: List / *List document (e.g. kubectl get -o yaml output) crashed the process: the list wrapper reached the fake dynamic tracker's addList path and panicked, with no recover in the action stack. Detect list wrappers in parseLocalLookupResources and expand them into their items before building the fake client. Each item flows through the same apiVersion validation and dedup as top-level documents, with file/document/item context in parse errors.
Signed-off-by: Dmitry Mordvinov <[email protected]>
Signed-off-by: Dmitry Mordvinov <[email protected]>
Signed-off-by: Dmitry Mordvinov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.