feat: Search for people - #120
Open
misterikkit wants to merge 5 commits into
Open
Conversation
Add support for /people/search. The form is much simpler than /works/search, having only three fields. And a `User` object is much simpler, needing only the username. In theory, more of the user data could be parsed from the search results, but calling user.reload() seems like a better choice. I tried to keep the API consistent with AO3.Search, but chose 'all_fields' instead of 'any_field' in order to be consistent with the AO3 people search form. Update the version to 2.4.0 to indicate new capability added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for /people/search. The form is much simpler than
/works/search, having only three fields. And a
Userobject is muchsimpler, needing only the username.
In theory, more of the user data could be parsed from the search
results, but calling user.reload() seems like a better choice.
I tried to keep the API consistent with AO3.Search, but chose
'all_fields' instead of 'any_field' in order to be consistent with the
AO3 people search form.
Update the version to 2.4.0 to indicate new capability added.