WTEL-9725: Return contact etag in agent chats response#140
Open
vlad-marusyk-wt wants to merge 1 commit into
Open
WTEL-9725: Return contact etag in agent chats response#140vlad-marusyk-wt wants to merge 1 commit into
vlad-marusyk-wt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
Роут GET /api/agent/chats повертав обʼєкт contact без поля etag (лише id, type, name). Фронт будує посилання на картку контакта за contact.etag, тож отримував undefined, і перехід на картку у режимі Read only ламався.
etag контакта не зберігається в БД, його кодує сам сервіс contacts, тому chat_manager, який збирає контакт напряму з таблиць contacts.* через SQL, віддати etag не міг.
Вирішення
chat_manager не вираховує etag, а доспрашує його у самого сервіса contacts і дозаповнює відповідь. Запит іде одним батчем на сторінку під токеном агента. Якщо contacts недоступний, список чатів усе одно повертається, просто без etag.