Skip to content

Fix Chrome history-navigation success detection for query/hash URL changes#202

Closed
Copilot wants to merge 1 commit into
Ayush7614/feat/history-toolsfrom
copilot/fix-code-review-suggestion
Closed

Fix Chrome history-navigation success detection for query/hash URL changes#202
Copilot wants to merge 1 commit into
Ayush7614/feat/history-toolsfrom
copilot/fix-code-review-suggestion

Conversation

Copilot AI commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

The reviewed issue was a false negative in go_back/go_forward: success detection compared normalized URLs that drop query/hash, so valid history moves like ?page=2 -> ?page=1 or #/inbox -> #/sent could be reported as “no earlier/later entry”.

  • Behavior fix (Chrome agent)

    • Updated go_back/go_forward post-navigation verification to compare full URLs instead of _normalizeUrl(...).
    • This preserves query-string and fragment differences when determining whether history navigation actually changed page state.
  • Focused regression coverage

    • Added a Chrome unit test for query/hash-only back navigation transitions to ensure these cases are treated as successful.
// Before
if (this._normalizeUrl(afterUrl) === this._normalizeUrl(probe.before)) { ... }

// After
if (afterUrl === probe.before) { ... }

@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webbrain Ready Ready Preview, Comment Jun 27, 2026 4:08pm

Copilot AI changed the title [WIP] Fix code based on review comment Fix Chrome history-navigation success detection for query/hash URL changes Jun 27, 2026
Copilot AI requested a review from webbrain-one June 27, 2026 16:14
@esokullu esokullu marked this pull request as ready for review June 27, 2026 17:19
@esokullu esokullu changed the base branch from main to Ayush7614/feat/history-tools June 27, 2026 17:20
@esokullu esokullu closed this Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants