fixing pagination warning#116
Merged
Merged
Conversation
Closed
|
There was a problem hiding this comment.
Pull request overview
Fixes the Spring Data warning about unstable PageImpl JSON serialization by switching Spring Data page serialization to the stable DTO-based format and updating affected controller tests accordingly.
Changes:
- Enable Spring Data web support with
pageSerializationMode = VIA_DTOto avoid thePageImplserialization warning. - Update multiple controller unit/integration tests to assert pagination metadata under the new
"page"JSON node (and stop asserting the removed"empty"field).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/br/com/webbudget/infrastructure/config/core/JacksonConfiguration.kt | Enables Spring Data’s stable page serialization mode globally. |
| src/test/kotlin/br/com/webbudget/controllers/registration/WalletControllerUTest.kt | Adjusts pagination JSON assertions to match the new "page" structure. |
| src/test/kotlin/br/com/webbudget/controllers/registration/FinancialPeriodControllerUTest.kt | Adjusts pagination JSON assertions to match the new "page" structure (multiple tests). |
| src/test/kotlin/br/com/webbudget/controllers/registration/CostCenterControllerUTest.kt | Adjusts pagination JSON assertions to match the new "page" structure. |
| src/test/kotlin/br/com/webbudget/controllers/registration/ClassificationControllerUTest.kt | Adjusts pagination JSON assertions to match the new "page" structure. |
| src/test/kotlin/br/com/webbudget/controllers/registration/CardControllerUTest.kt | Adjusts pagination JSON assertions to match the new "page" structure. |
| src/test/kotlin/br/com/webbudget/controllers/administration/UserControllerUTest.kt | Adjusts pagination JSON assertions to match the new "page" structure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixing pagination warning
What's changed?
Jackson configuration
How can I test it?
Run the tests
Additional context
Issue #100