a few fixes in test.c#4
Open
Vigeant wants to merge 2 commits into
Open
Conversation
Vigeant
commented
May 4, 2020
Vigeant
commented
- added a missing include,
- allocate enough room for a null byte on the heap for msg (the first test failed on my system)
- initialize the msg heap chunk with null bytes.
Fixed test to allocate anough memory to store a nullbyte. The first test was failing on my system because msg was not terminated by a null byte and failed the strcmp in certain conditions. I also added iitialization of the heap chunk.
|
I confirm that the test fails on Raspberry Pi unless this patch b6eab95 is applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.