Skip to content

fit: Add decoder - #391

Closed
wader wants to merge 1 commit into
masterfrom
fit
Closed

fit: Add decoder#391
wader wants to merge 1 commit into
masterfrom
fit

Conversation

@wader

@wader wader commented Aug 22, 2022

Copy link
Copy Markdown
Owner

No description provided.

@wader

wader commented Feb 12, 2023

Copy link
Copy Markdown
Owner Author

@mlofjard Hey, i noticed you working on a FIT decoder, maybe this stalled PR could be of interest? feel free to copy or get inspiration from it! I just rebased it and made sure it still builds and decodes somewhat.

Don't remember how far i got and what were left to do, but i think it i was thinking about adding support to use some definition file from garmin to map ids in a nicer way. I guess either by embedding it or add an option to the decoder to load it externally somehow at decode time.

@mlofjard

Copy link
Copy Markdown
Contributor

Hi @wader, yes it started as a fun weekend project after your FOSDEM talk, and then I found this PR a few days later. I'm currently exploring generating the definitions from Garmins long excel sheet, while also adding more value formatting functions for stuff like dates, coordinates and such.

@wader

wader commented Feb 12, 2023

Copy link
Copy Markdown
Owner Author

Aha I see, that sounds great. We can probably replace this PR with what your working on. Feel free to create a PR early even if things are hacky or broken if you want feedback or review

@wader

wader commented May 1, 2023

Copy link
Copy Markdown
Owner Author

@mlofjard Hej! i did a quite large refactor how formats and register some days ago. I rebased this PR with the new way of doing it, should hopefully for you be just a copy/paste of the init function.

@mlofjard

mlofjard commented May 5, 2023

Copy link
Copy Markdown
Contributor

@wader Nice. I've been dragged around on other stuff lately, but today I might have some time to finally get back into it. Will rebase my fork and try it out.

@wader

wader commented May 5, 2023

Copy link
Copy Markdown
Owner Author

@mlofjard No hurry, nice to hear your still interested

@wader

wader commented Feb 5, 2024

Copy link
Copy Markdown
Owner Author

@mlofjard Tja, was nice to meet you! hope you made some progress and feel free to open a PR even if the code is very WIP if you want feedback or discuss something

@mlofjard

mlofjard commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

@wader Yeah, it was funny that we ended up at the same hotel this year. I actually got it working, and it reads all the example files from the SDK now (the ones with dynamic developer fields were the final headache). A PR has been made.

@wader

wader commented Feb 6, 2024

Copy link
Copy Markdown
Owner Author

@wader Yeah, it was funny that we ended up at the same hotel this year. I actually got it working, and it reads all the example files from the SDK now (the ones with dynamic developer fields were the final headache). A PR has been made.

Yeap! feel i should have stayed and chatted a bit more :) sound like really good progress! mm i remember there were some quite tricky things in the spec to understand.

@wader

wader commented Feb 6, 2024

Copy link
Copy Markdown
Owner Author

Replaced by #863

@wader wader closed this Feb 6, 2024
@wader

wader commented Feb 6, 2024

Copy link
Copy Markdown
Owner Author

@mlofjard i noticed this PR has a test.fit test file... but don't remember were i got it from :(

@wader
wader deleted the fit branch May 5, 2026 14:27
@wader
wader restored the fit branch May 5, 2026 14:27
@wader
wader deleted the fit branch May 5, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants