ins elements: forces underline to be set below baseline to improve readability - #388
ins elements: forces underline to be set below baseline to improve readability#388deniak wants to merge 2 commits into
Conversation
daniel-montalvo
left a comment
There was a problem hiding this comment.
Thanks much @deniak
I am approving as I understand this is an improvement with respec to what we currently have. Just pinging also @kfranqueiro for the visual check :-)
|
Yes, I can confirm this seems to improve things. I would also note that the problem being addressed seemed to be worse in Chromium-based browsers than in Firefox-based browsers or Safari due to the dashed underline being thicker by default, so I wonder if setting |
Yes, I does seem to improve readability on chromium-based browsers but in Firefox, it actually increases the default thickness. I pushed a version with the value |
fix #359
Moving the underline of
inselements below the baseline should improve readability