Skip to content

ins elements: forces underline to be set below baseline to improve readability - #388

Open
deniak wants to merge 2 commits into
gh-pagesfrom
ins-underline-position
Open

ins elements: forces underline to be set below baseline to improve readability#388
deniak wants to merge 2 commits into
gh-pagesfrom
ins-underline-position

Conversation

@deniak

@deniak deniak commented Jul 27, 2026

Copy link
Copy Markdown
Member

fix #359

Moving the underline of ins elements below the baseline should improve readability

@daniel-montalvo daniel-montalvo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much @deniak

I am approving as I understand this is an improvement with respec to what we currently have. Just pinging also @kfranqueiro for the visual check :-)

@kfranqueiro

kfranqueiro commented Jul 29, 2026

Copy link
Copy Markdown

Yes, I can confirm this seems to improve things.

I would also note that the problem being addressed seemed to be worse in Chromium-based browsers than in Firefox-based browsers or Safari due to the dashed underline being thicker by default, so I wonder if setting text-decoration-thickness: 1px; would be useful in addition to this change?

@deniak

deniak commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

Yes, I can confirm this seems to improve things.

I would also note that the problem being addressed seemed to be worse in Chromium-based browsers than in Firefox-based browsers or Safari due to the dashed underline being thicker by default, so I wonder if setting text-decoration-thickness: 1px; would be useful in addition to this change?

Yes, I does seem to improve readability on chromium-based browsers but in Firefox, it actually increases the default thickness. I pushed a version with the value from-font which seems to render better across the different browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document convention - Unnecessarily hard to read high stakes information

3 participants