Skip to content

Editorial: queue a task to reject promise in InstallEvent.addRoutes #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monica-ch merged 1 commit into from
Aug 4, 2026
Merged

Editorial: queue a task to reject promise in InstallEvent.addRoutes #1839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1639,14 +1639,17 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/

Note: this step is for making |lifetimePromise| always fullfilled to avoid the install event failure.

1. Let |serviceWorkerEventLoop| be the [=current global object=]'s [=event loop=].
1. [=queue/Enqueue=] the following steps to [=[[service worker queue]]=]:
1. Let |allRules| be a copy of |serviceWorker|'s [=list of router rules=].
1. For each |rule| of |rules|:
1. Append |rule| to |allRules|.

1. If running the [=Check Router Registration Limit=] with |allRules| returns false, reject |promise| with a {{TypeError}}.
1. If running the [=Check Router Registration Limit=] with |allRules| returns false, then:
1. [=Queue a task=] to run the following steps on |serviceWorkerEventLoop| using the [=DOM manipulation task source=]:
1. Reject |promise| with a {{TypeError}}.
1. Abort these steps.
1. Set |serviceWorker|'s [=service worker/list of router rules=] to |allRules|.
1. Let |serviceWorkerEventLoop| be the [=current global object=]'s [=event loop=].
1. [=Queue a task=] to run the following steps on |serviceWorkerEventLoop| using the [=DOM manipulation task source=]:
1. Resolve |promise| with undefined.
1. Return |promise|.
Expand Down
Loading