perf: Improved performance and reduced memory consumption#90
Open
negezor wants to merge 14 commits into
Open
Conversation
Refactor isNullish to use strict equality checks instead of indexOf. This enhances performance and readability.
toRef does not create a WatchEffect, unlike computed
…d is already unmounted
|
These changes would be greatly appreciated as the |
Author
|
@adamberecz sorry to bother you, but could you please review this PR? I still have to use a fork of this repository and consider the same for #91? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. Applying all the same optimizations as here vueform/multiselect#411. In this world, a little optimization never hurt anyone 😅
In addition to the previous PR, the watchers are grouped here to reduce the number of
effectScopecreated. And since we don't need to make all nouislider properties reactive, it's better to leave this job toshallowRef().