fix(markdown-renderer): render callout icons as inline SVG instead of external asset#86
Open
julia-rabello wants to merge 1 commit into
Open
fix(markdown-renderer): render callout icons as inline SVG instead of external asset#86julia-rabello wants to merge 1 commit into
julia-rabello wants to merge 1 commit into
Conversation
… external asset The vtex-dev-portal-navigation DigitalOcean Space that callout icons (info, warning, danger, success) were loaded from via CSS background-image no longer exists (404 NoSuchBucket), so icons silently disappeared while the colored background/border still rendered. Icons are now inline SVGs bundled with the component, removing the external dependency entirely.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
4 tasks
Contributor
Author
|
Tracked in Jira: EDU-19009 Related fix in the sibling repo: vtexdocs/RapiDoc#48 Related Slack thread: https://vtex.slack.com/archives/GM3C9C3QS/p1783599938129019 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Callout/admonition icons (info, warning, danger, success) were loaded via a CSS
:beforebackground-imagepointing at the DigitalOcean Spacevtex-dev-portal-navigation.fra1.digitaloceanspaces.com. That bucket no longer exists (confirmed404 NoSuchBucketon all four icon URLs), so icons silently disappeared while the colored background/border still rendered fine — since those don't depend on an external resource.This PR replaces the external image dependency with an inline SVG icon bundled directly in the
Calloutcomponent, so rendering no longer depends on that (or any) external asset host.Also added
Callout.stories.tsxcovering all four variants (info/warning/danger/success), since there was previously no direct Storybook coverage for this component — it was only reachable indirectly through the MDX pipeline.Types of changes
Test plan
Info,Warning,Danger,Success) render their icons correctly with no network requests to the old bucketWarningvariant visually matches the expected design (orange circle with "!")