Solve Document Field Problems with the blockDocument property#143
Open
TiagoGranelli wants to merge 3 commits into
Open
Solve Document Field Problems with the blockDocument property#143TiagoGranelli wants to merge 3 commits into
TiagoGranelli wants to merge 3 commits into
Conversation
fixed issue with blockDocument prop blocking field even when there was no document fixed issue with blockDocument prop blocking field before document is filled completely
added new "changing" property so we know when a field has changed
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
TiagoGranelli
marked this pull request as ready for review
February 8, 2022 19:23
4 tasks
NicholasPedroso
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Solve the problems of the document field (CPF). This fix also fixes the problem that this PR is fixing Solve the problem of the document field (CPF) blocking even with the empty document.
What problem is this solving?
This pull request is for fixing bugs, currently, this block document property has two issues that have been resolved in this PR:
How should this be manually tested?
If the blockDocument prop is active, the field should only block when there is a valid document saved
Field should not lock while typing
Field must not block if value is an empty string
WS to test
Workspace
Related to / Depends on?
vtex-apps/my-account#252
vtex-apps/my-account-commons#60
Screenshots or example usage
1st bugfix
Before
cpf.blocked.with.1.digit.mp4
After
field only block after submit
bugfix-cpf.blocked.after.submit.mp4
2nd bugfix
Before
After
Types of changes