docs: clarify deserved/guarantee vs capability in hierarchical queues#543
docs: clarify deserved/guarantee vs capability in hierarchical queues#543aeron-gh wants to merge 2 commits into
Conversation
The HierarchicalQueue page explained how capability behaves when a queue does not set it (it inherits up to the root queue's cluster-total default) but said nothing about deserved/guarantee when unset. Reword the trailing section so the lower-bound (deserved/guarantee, unset means 0) vs upper-bound (capability) behavior is clear, including that a child cannot set deserved/guarantee for a dimension its parent has not set. Signed-off-by: aeron-gh <[email protected]>
volcano-sh-bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @aeron-gh! It looks like this is your first PR to volcano-sh/website 🎉 |
volcano-sh-bot
added
the
size/XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in HierarchicalQueue.md to clarify how deserved, guarantee, and capability resource fields behave under the queue hierarchy. The reviewer pointed out that the corresponding Chinese translation file should also be updated to maintain consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
volcano-sh-bot
removed
the
do-not-merge/work-in-progress
Keep the Chinese page in sync with the English one, reusing its existing wording and adding the same lower-bound (deserved/guarantee) vs upper-bound (capability) explanation. Signed-off-by: aeron-gh <[email protected]>
volcano-sh-bot
added
size/S
|
@hajnalmt this is the docs change from volcano-sh/volcano#5634 : @yashisrani would appreciate your eyes too if you have a moment. |
|
@aeron-gh Thanks for improving this section. Nice improvement! |
|
/lgtm |
3 participants
The HierarchicalQueue page explained how
capabilitybehaves when unset (it inherits up to the root queue's cluster-total default) but said nothing aboutdeserved/guarantee. This reworks the trailing section to add that:deserved/guaranteeare lower bounds that default to 0, so a child cannot set them for a dimension its parent has not set, whilecapabilityis an upper bound.This is the lower-bound vs upper-bound distinction @hajnalmt described in volcano-sh/volcano#5634.
Fixes #542