Skip to content

Fix Chinese footer copyright year#541

Open
avinxshKD wants to merge 1 commit into
volcano-sh:masterfrom
avinxshKD:fix/chinese-footer-copyright
Open

Fix Chinese footer copyright year#541
avinxshKD wants to merge 1 commit into
volcano-sh:masterfrom
avinxshKD:fix/chinese-footer-copyright

Conversation

@avinxshKD

Copy link
Copy Markdown
  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines

@volcano-sh-bot volcano-sh-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 10, 2026
@volcano-sh-bot
volcano-sh-bot requested review from de6p and k82cn July 10, 2026 16:18
@volcano-sh-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thor-wl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the copyright year from 2025 to 2026 in the Chinese translation of the footer. The reviewer identified that the HTML structure in the footer message is malformed due to an unclosed div tag and provided a code suggestion to resolve this issue.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

{
"copyright": {
"message": "\n <div class=\"footer-content\">\n <p>Volcano是 <a href=\"https://www.cncf.io/\" target=\"_blank\" rel=\"noopener noreferrer\">云原生计算基金会</a> 孵化项目</p>\n <div class=\"footer__logo-container\">\n <img class=\"footer__logo\" alt=\"云原生计算基金会徽标\" src=\"/img/landing/logo_cloudnative.png\" />\n </div>\n <p>Linux基金会已注册并使用其商标。有关Linux基金会的商标列表,请参见 <a href=\"https://www.linuxfoundation.org/trademark-usage\" target=\"_blank\" rel=\"noopener noreferrer\">商标使用</a> 页面。</p>\n <p>版权所有©2025 @ Volcano 项目作者所有。保留一切权利。</p>\n ",
"message": "\n <div class=\"footer-content\">\n <p>Volcano是 <a href=\"https://www.cncf.io/\" target=\"_blank\" rel=\"noopener noreferrer\">云原生计算基金会</a> 孵化项目</p>\n <div class=\"footer__logo-container\">\n <img class=\"footer__logo\" alt=\"云原生计算基金会徽标\" src=\"/img/landing/logo_cloudnative.png\" />\n </div>\n <p>Linux基金会已注册并使用其商标。有关Linux基金会的商标列表,请参见 <a href=\"https://www.linuxfoundation.org/trademark-usage\" target=\"_blank\" rel=\"noopener noreferrer\">商标使用</a> 页面。</p>\n <p>版权所有©2026 @ Volcano 项目作者所有。保留一切权利。</p>\n ",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The HTML structure is malformed because the opening <div class="footer-content"> tag is never closed. Please add the closing </div> tag at the end of the string to prevent potential layout issues on the page.

Suggested change
"message": "\n <div class=\"footer-content\">\n <p>Volcano是 <a href=\"https://www.cncf.io/\" target=\"_blank\" rel=\"noopener noreferrer\">云原生计算基金会</a> 孵化项目</p>\n <div class=\"footer__logo-container\">\n <img class=\"footer__logo\" alt=\"云原生计算基金会徽标\" src=\"/img/landing/logo_cloudnative.png\" />\n </div>\n <p>Linux基金会已注册并使用其商标。有关Linux基金会的商标列表,请参见 <a href=\"https://www.linuxfoundation.org/trademark-usage\" target=\"_blank\" rel=\"noopener noreferrer\">商标使用</a> 页面。</p>\n <p>版权所有©2026 @ Volcano 项目作者所有。保留一切权利。</p>\n ",
"message": "\n <div class=\"footer-content\">\n <p>Volcano是 <a href=\"https://www.cncf.io/\" target=\"_blank\" rel=\"noopener noreferrer\">云原生计算基金会</a> 孵化项目</p>\n <div class=\"footer__logo-container\">\n <img class=\"footer__logo\" alt=\"云原生计算基金会徽标\" src=\"/img/landing/logo_cloudnative.png\" />\n </div>\n <p>Linux基金会已注册并使用其商标。有关Linux基金会的商标列表,请参见 <a href=\"https://www.linuxfoundation.org/trademark-usage\" target=\"_blank\" rel=\"noopener noreferrer\">商标使用</a> 页面。</p>\n <p>版权所有©2026 @ Volcano 项目作者所有。保留一切权利。</p>\n </div>\n ",

@yashisrani

Copy link
Copy Markdown
Contributor

@avinxshKD Replace the hardcoded copyright year with a dynamically generated current year.

This ensures the footer remains accurate automatically each year, eliminates the need for annual manual updates, and keeps the copyright notice consistent across all localized versions of the website.

@avinxshKD

Copy link
Copy Markdown
Author

@yashisrani right, agreed

Signed-off-by: Avinash Kumar Deepak <[email protected]>
@avinxshKD
avinxshKD force-pushed the fix/chinese-footer-copyright branch from 61835a6 to cf40bb2 Compare July 10, 2026 17:28
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2026
@yashisrani

Copy link
Copy Markdown
Contributor

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026
@avinxshKD

Copy link
Copy Markdown
Author

@hajnalmt @JesseStutler Ptal when get chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Footer copyright year is outdated on Chinese language version

3 participants