Fix Chinese footer copyright year#541
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates the copyright year from 2025 to 2026 in the Chinese translation of the footer. The reviewer identified that the HTML structure in the footer message is malformed due to an unclosed div tag and provided a code suggestion to resolve this issue.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| { | ||
| "copyright": { | ||
| "message": "\n <div class=\"footer-content\">\n <p>Volcano是 <a href=\"https://www.cncf.io/\" target=\"_blank\" rel=\"noopener noreferrer\">云原生计算基金会</a> 孵化项目</p>\n <div class=\"footer__logo-container\">\n <img class=\"footer__logo\" alt=\"云原生计算基金会徽标\" src=\"/img/landing/logo_cloudnative.png\" />\n </div>\n <p>Linux基金会已注册并使用其商标。有关Linux基金会的商标列表,请参见 <a href=\"https://www.linuxfoundation.org/trademark-usage\" target=\"_blank\" rel=\"noopener noreferrer\">商标使用</a> 页面。</p>\n <p>版权所有©2025 @ Volcano 项目作者所有。保留一切权利。</p>\n ", | ||
| "message": "\n <div class=\"footer-content\">\n <p>Volcano是 <a href=\"https://www.cncf.io/\" target=\"_blank\" rel=\"noopener noreferrer\">云原生计算基金会</a> 孵化项目</p>\n <div class=\"footer__logo-container\">\n <img class=\"footer__logo\" alt=\"云原生计算基金会徽标\" src=\"/img/landing/logo_cloudnative.png\" />\n </div>\n <p>Linux基金会已注册并使用其商标。有关Linux基金会的商标列表,请参见 <a href=\"https://www.linuxfoundation.org/trademark-usage\" target=\"_blank\" rel=\"noopener noreferrer\">商标使用</a> 页面。</p>\n <p>版权所有©2026 @ Volcano 项目作者所有。保留一切权利。</p>\n ", |
There was a problem hiding this comment.
The HTML structure is malformed because the opening <div class="footer-content"> tag is never closed. Please add the closing </div> tag at the end of the string to prevent potential layout issues on the page.
| "message": "\n <div class=\"footer-content\">\n <p>Volcano是 <a href=\"https://www.cncf.io/\" target=\"_blank\" rel=\"noopener noreferrer\">云原生计算基金会</a> 孵化项目</p>\n <div class=\"footer__logo-container\">\n <img class=\"footer__logo\" alt=\"云原生计算基金会徽标\" src=\"/img/landing/logo_cloudnative.png\" />\n </div>\n <p>Linux基金会已注册并使用其商标。有关Linux基金会的商标列表,请参见 <a href=\"https://www.linuxfoundation.org/trademark-usage\" target=\"_blank\" rel=\"noopener noreferrer\">商标使用</a> 页面。</p>\n <p>版权所有©2026 @ Volcano 项目作者所有。保留一切权利。</p>\n ", | |
| "message": "\n <div class=\"footer-content\">\n <p>Volcano是 <a href=\"https://www.cncf.io/\" target=\"_blank\" rel=\"noopener noreferrer\">云原生计算基金会</a> 孵化项目</p>\n <div class=\"footer__logo-container\">\n <img class=\"footer__logo\" alt=\"云原生计算基金会徽标\" src=\"/img/landing/logo_cloudnative.png\" />\n </div>\n <p>Linux基金会已注册并使用其商标。有关Linux基金会的商标列表,请参见 <a href=\"https://www.linuxfoundation.org/trademark-usage\" target=\"_blank\" rel=\"noopener noreferrer\">商标使用</a> 页面。</p>\n <p>版权所有©2026 @ Volcano 项目作者所有。保留一切权利。</p>\n </div>\n ", |
|
@avinxshKD Replace the hardcoded copyright year with a dynamically generated current year. This ensures the footer remains accurate automatically each year, eliminates the need for annual manual updates, and keeps the copyright notice consistent across all localized versions of the website. |
|
@yashisrani right, agreed |
Signed-off-by: Avinash Kumar Deepak <[email protected]>
61835a6 to
cf40bb2
Compare
|
/lgtm |
|
@hajnalmt @JesseStutler Ptal when get chance |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
/kind bug
What this PR does / why we need it:
Updates the Chinese footer copyright year from 2025 to 2026.
Which issue(s) this PR fixes:
Fixes [Bug]: Footer copyright year is outdated on Chinese language version #540