fix: replace incorrect @ symbol with © in footer copyright#539
fix: replace incorrect @ symbol with © in footer copyright#539KrishnaParihar1 wants to merge 1 commit into
Conversation
The footer on both English and Chinese pages used '@' instead of the standard copyright symbol '©'. Fixed in docusaurus.config.js and the zh-Hans i18n translation file. Signed-off-by: Krishna <your-email> Signed-off-by: Krishna Parihar <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @KrishnaParihar1! It looks like this is your first PR to volcano-sh/website 🎉 |
volcano-sh-bot
added
the
size/XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the copyright text formatting in the footer of the website within docusaurus.config.js and its Chinese translation file. The review feedback correctly identifies that the <div class="footer-content"> tag is left unclosed in both files, which could lead to invalid HTML rendering, and provides actionable suggestions to close the tags properly.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| </div> | ||
| <p>The Linux Foundation has registered trademarks and uses trademarks. For a list of trademarks of The Linux Foundation, please see our <a href="https://www.linuxfoundation.org/trademark-usage" target="_blank" rel="noopener noreferrer">Trademark Usage</a> page.</p> | ||
| <p>${new Date().getFullYear()} @ Volcano Project Authors. All rights reserved.</p> | ||
| <p>© ${new Date().getFullYear()} Volcano Project Authors. All rights reserved.</p> |
There was a problem hiding this comment.
The <div class="footer-content"> tag opened on line 178 is never closed. This results in invalid HTML, which can cause layout issues or rendering bugs in some browsers. Please add a closing </div> tag.
<p>© ${new Date().getFullYear()} Volcano Project Authors. All rights reserved.</p>
</div>| { | ||
| "copyright": { | ||
| "message": "\n <div class=\"footer-content\">\n <p>Volcano是 <a href=\"https://www.cncf.io/\" target=\"_blank\" rel=\"noopener noreferrer\">云原生计算基金会</a> 孵化项目</p>\n <div class=\"footer__logo-container\">\n <img class=\"footer__logo\" alt=\"云原生计算基金会徽标\" src=\"/img/landing/logo_cloudnative.png\" />\n </div>\n <p>Linux基金会已注册并使用其商标。有关Linux基金会的商标列表，请参见 <a href=\"https://www.linuxfoundation.org/trademark-usage\" target=\"_blank\" rel=\"noopener noreferrer\">商标使用</a> 页面。</p>\n <p>版权所有©2025 @ Volcano 项目作者所有。保留一切权利。</p>\n ", | ||
| "message": "\n <div class=\"footer-content\">\n <p>Volcano是 <a href=\"https://www.cncf.io/\" target=\"_blank\" rel=\"noopener noreferrer\">云原生计算基金会</a> 孵化项目</p>\n <div class=\"footer__logo-container\">\n <img class=\"footer__logo\" alt=\"云原生计算基金会徽标\" src=\"/img/landing/logo_cloudnative.png\" />\n </div>\n <p>Linux基金会已注册并使用其商标。有关Linux基金会的商标列表，请参见 <a href=\"https://www.linuxfoundation.org/trademark-usage\" target=\"_blank\" rel=\"noopener noreferrer\">商标使用</a> 页面。</p>\n <p>版权所有 © 2025 Volcano 项目作者所有。保留一切权利。</p>\n ", |
There was a problem hiding this comment.
Similarly, the <div class="footer-content"> tag is not closed in the Chinese translation. Please add a closing </div> tag to ensure valid HTML structure.
| "message": "\n <div class=\"footer-content\">\n <p>Volcano是 <a href=\"https://www.cncf.io/\" target=\"_blank\" rel=\"noopener noreferrer\">云原生计算基金会</a> 孵化项目</p>\n <div class=\"footer__logo-container\">\n <img class=\"footer__logo\" alt=\"云原生计算基金会徽标\" src=\"/img/landing/logo_cloudnative.png\" />\n </div>\n <p>Linux基金会已注册并使用其商标。有关Linux基金会的商标列表，请参见 <a href=\"https://www.linuxfoundation.org/trademark-usage\" target=\"_blank\" rel=\"noopener noreferrer\">商标使用</a> 页面。</p>\n <p>版权所有 © 2025 Volcano 项目作者所有。保留一切权利。</p>\n ", | |
| "message": "\n <div class=\"footer-content\">\n <p>Volcano是 <a href=\"https://www.cncf.io/\" target=\"_blank\" rel=\"noopener noreferrer\">云原生计算基金会</a> 孵化项目</p>\n <div class=\"footer__logo-container\">\n <img class=\"footer__logo\" alt=\"云原生计算基金会徽标\" src=\"/img/landing/logo_cloudnative.png\" />\n </div>\n <p>Linux基金会已注册并使用其商标。有关Linux基金会的商标列表，请参见 <a href=\"https://www.linuxfoundation.org/trademark-usage\" target=\"_blank\" rel=\"noopener noreferrer\">商标使用</a> 页面。</p>\n <p>版权所有 © 2025 Volcano 项目作者所有。保留一切权利。</p>\n </div>\n ", |
|
@KrishnaParihar1 please close this pr . the issue is assigned to me and i am working on it. |
|
Hey @vanshika2720, I apologize—I didn't notice that you had been assigned this issue. I identified the problem, opened the issue, and started working on the fix before realizing it. I've already completed a PR that addresses the issue. Rather than closing it, I'd appreciate it if you could review it and suggest any improvements if needed. If the maintainers prefer your implementation instead, I'll respect their decision, but I think it would be worthwhile to evaluate the existing PR since the work is already done. |
|
@KrishnaParihar1 yeah sure. it's a small and good change . looks good to me |
|
/lgtm |
4 participants
Description
The footer on both the English and Chinese pages used
@instead of the standard copyright symbol©. This PR replaces the incorrect symbol with©in bothdocusaurus.config.jsandi18n/zh-Hans/docusaurus-theme-classic/footer.json.Additionally, the Chinese footer contained both
©and@(©2025 @), resulting in duplicate copyright symbols. This has been corrected so the footer uses a single, standard copyright symbol.Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
/kind bug
What this PR does / why we need it
@symbol with the standard copyright symbol©in the English footer.@symbol and ensuring only©is used.Which issue(s) this PR fixes
Fixes #538