-
Notifications
You must be signed in to change notification settings - Fork 125
docs: sync missing plugin documentation from volcano core repository #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hemantch01
wants to merge
5
commits into
volcano-sh:master
Choose a base branch
from
hemantch01:feat/sync-plugin-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1515405
docs: sync and setup plugin documentation
hemantch01 b5b3ae6
docs: update svg images
hemantch01 d6bfa7f
fix: resolve sidebar translation key conflict for Plugins categories
hemantch01 8912fe6
fix: update broken links across blog, versioned docs, and i18n after …
hemantch01 4415a13
docs: resolve PR feedback for scheduler and controller plugins
hemantch01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,3 +21,4 @@ yarn-error.log* | |
|
|
||
|
|
||
|
|
||
| volcano/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| { | ||
| "label": "Contribution", | ||
| "position": 9 | ||
| "position": 10 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| title: Overview | ||
| --- | ||
|
|
||
| ## Introduction | ||
|
|
||
| The Volcano Job Controller manages the lifecycle of jobs and dynamically configures job environments using plugins such as SSH, SVC, MPI, and PyTorch. |
|
hemantch01 marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "label": "Plugins", | ||
|
hemantch01 marked this conversation as resolved.
|
||
| "key": "controller-plugins" | ||
| } | ||
2 changes: 1 addition & 1 deletion
2
...Guide/user_guide_how_to_use_env_plugin.md → docs/Controller/Plugins/env.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| --- | ||
| title: "Volcano Job Plugin -- Env User Guide" | ||
| title: Env | ||
|
|
||
| --- | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| --- | ||
| title: HCCLRank | ||
| --- | ||
|
|
||
| ## Introduction | ||
|
|
||
| In distributed AI training, particularly when using Ascend NPUs (Neural Processing Units) or MindSpore frameworks, the compute nodes need a deterministic rank or index to communicate over HCCL (Huawei Collective Communication Library). | ||
|
|
||
| The **HCCLRank Plugin** is a Volcano Job plugin that automatically injects a `hccl/rankIndex` annotation into the Pods of a Volcano Job. It calculates a unique rank for each pod based on its task type (`master` or `worker`) and its replica index. | ||
|
|
||
| ## Mechanism | ||
|
|
||
| During the Pod creation phase (`OnPodCreate`), the HCCLRank Plugin intercepts the pod and adds the `hccl/rankIndex` annotation to it. | ||
|
|
||
| The calculation is as follows: | ||
| - **Master Role**: Rank = Pod Index | ||
| - **Worker Role**: Rank = (Total Master Replicas) + Pod Index | ||
|
|
||
| If the Pod already has a `RANK` environment variable defined in its container specifications, the plugin will use that value instead and simply map it to the `hccl/rankIndex` annotation. | ||
|
|
||
| ## Configuration | ||
|
|
||
| To enable the HCCLRank plugin, configure it within the Volcano job controller's configuration or add it to the `plugins` field of your `VolcanoJob` spec. | ||
|
|
||
| ```yaml | ||
| apiVersion: batch.volcano.sh/v1alpha1 | ||
| kind: Job | ||
| metadata: | ||
| name: ascend-distributed-training | ||
| spec: | ||
| minAvailable: 3 | ||
| schedulerName: volcano | ||
| plugins: | ||
| hcclrank: | ||
| - --master=master | ||
| - --worker=worker | ||
| tasks: | ||
| - replicas: 1 | ||
| name: master | ||
| template: | ||
| spec: | ||
| containers: | ||
| - name: master | ||
| image: my-ascend-image | ||
| - replicas: 2 | ||
| name: worker | ||
| template: | ||
| spec: | ||
| containers: | ||
| - name: worker | ||
| image: my-ascend-image | ||
| ``` | ||
|
|
||
| ### Arguments | ||
|
|
||
| The HCCLRank plugin supports overriding the default task names used to identify master and worker roles: | ||
|
|
||
| - **`--master`**: The name of the master role task in your Job spec. Default is `master`. | ||
| - **`--worker`**: The name of the worker role task in your Job spec. Default is `worker`. |
4 changes: 2 additions & 2 deletions
4
...Guide/user_guide_how_to_use_mpi_plugin.md → docs/Controller/Plugins/mpi.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| --- | ||
| title: "MPI Plugin User Guide" | ||
| --- | ||
| title: Message Passing Interface (MPI) | ||
|
|
||
| --- | ||
|
|
||
|
|
||
2 changes: 1 addition & 1 deletion
2
...e/user_guide_how_to_use_pytorch_plugin.md → docs/Controller/Plugins/pytorch.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| --- | ||
| title: "Pytorch Plugin User Guide" | ||
| title: Pytorch | ||
| --- | ||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One sentence is a bit thin for what is now the landing page of the Controller section. Could you expand this a little — e.g. what the Job Controller actually reconciles (Job, PodGroup, tasks, lifecycle policies), how plugins hook into it (OnJobAdd / OnPodCreate / etc.), and a short index linking to each plugin page under ./Plugins/ (env, ssh, svc, tensorflow, mpi, pytorch, ray, hcclrank).
Also worth noting for a follow-up: the Controller section can later host a Policies page too (the lifecycle policies on Job/Task, e.g. PodEvicted / TaskCompleted / TaskFailed actions). No need to include that in this PR, just calling it out so we have a slot for it.
Same expansion needed on the matching i18n/zh-Hans/.../Controller/Overview.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will be adding picture and more description, but this pr is getting too long so i will fix it in next pr. or i can add in this pr your call.