-
Notifications
You must be signed in to change notification settings - Fork 125
docs: fix typo deserverd→deserved and add multi-tenant Queue example #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pushtisonawala
wants to merge
1
commit into
volcano-sh:master
Choose a base branch
from
pushtisonawala:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -89,11 +89,49 @@ This field is used to configure [hierarchical queues](/docs/KeyFeatures/Hierarch | |||||
| `Closing` indicates that the queue is becoming unavailable. It is a transient state. A `Closing` queue cannot accept any new PodGroups. | ||||||
| ### Unknown | ||||||
| `Unknown` indicates that the queue status is unknown because of unexpected situations such as network jitter. | ||||||
|
|
||||||
| ## Multi-tenant Example | ||||||
|
|
||||||
| In a multi-tenant cluster, each team can have their own Queue with separate resource limits. Here's an example with two teams: | ||||||
|
|
||||||
| ```yaml | ||||||
| # Team A's queue - gets 4 CPUs guaranteed | ||||||
| apiVersion: scheduling.volcano.sh/v1beta1 | ||||||
| kind: Queue | ||||||
| metadata: | ||||||
| name: team-a | ||||||
| spec: | ||||||
| capability: | ||||||
| cpu: "8" | ||||||
| memory: 16Gi | ||||||
| guarantee: | ||||||
| resource: | ||||||
| cpu: "4" | ||||||
| memory: 8Gi | ||||||
| reclaimable: true | ||||||
| --- | ||||||
| # Team B's queue - gets 4 CPUs guaranteed | ||||||
| apiVersion: scheduling.volcano.sh/v1beta1 | ||||||
| kind: Queue | ||||||
| metadata: | ||||||
| name: team-b | ||||||
| spec: | ||||||
| capability: | ||||||
| cpu: "8" | ||||||
| memory: 16Gi | ||||||
| guarantee: | ||||||
| resource: | ||||||
| cpu: "4" | ||||||
| memory: 8Gi | ||||||
| reclaimable: true | ||||||
| ``` | ||||||
|
|
||||||
| Each team submits their jobs to their own queue. If Team A's jobs are idle, Team B can use the extra resources, and vice versa. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The explanation can be improved by using more precise terminology and correcting the grammatical consistency (using 'its' for the singular 'team').
Suggested change
|
||||||
|
|
||||||
| ## Note | ||||||
| #### default Queue | ||||||
| When Volcano starts, it automatically creates queue `default` whose `weight` is `1`. Subsequent jobs that are not assigned to a queue will be assigned to queue `default`. | ||||||
| #### root queue | ||||||
| When Volcano starts, it also creates a queue named root by default. This queue is used when the [hierarchical queue](/docs/KeyFeatures/HierarchicalQueue) feature is enabled, serving as the root queue for all queues, with the default queue being a child queue of the root queue. | ||||||
|
|
||||||
| > For more information on queue usage scenarios, please refer to [Queue Resource Management](/docs/KeyFeatures/QueueResourceManagement) | ||||||
| > For more information on queue usage scenarios, please refer to [Queue Resource Management](/docs/KeyFeatures/QueueResourceManagement) | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The multi-tenant example uses the
guaranteefield to define resource limits, but the description at line 142 states that teams can share idle resources. According to the Volcano documentation (see line 57 of this file and line 30 ofqueue_resource_management.md),guaranteeresources are strictly reserved and cannot be used by other queues even if idle.To achieve the described sharing behavior, the
deservedfield should be used instead. Thedeservedfield defines the fair-share amount that can be borrowed by other queues when not in use. Furthermore,deservedis a mandatory field when using the recommendedcapacityplugin (as noted inqueue_resource_management.mdline 35).