Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 22 additions & 31 deletions community-membership.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ This document gives a brief overview of the Volcano community roles with the req
| [Member](#member) | Sponsor from 2 approvers, active in community, contributed to Volcano | Welcome and guide new contributors | Volcano GitHub organization Member |
| [Reivewer](#reviewer) | Sponsor from 2 maintainers, has basic experience and knowledge of domain, actively contributed to code and review | Review contributions from community members | Write access to specific packages in relevant repository |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also note typo Reivewer

| [Approver](#approver) | Sponsor from 2 maintainers, has good experience and knowledge of domain, actively contributed to code and review | Review and approve contributions from community members | Write access to specific packages in relevant repository |
| [Maintainer](#maintainer) | Sponsor from 2 owners, shown good technical judgement in feature design/development and PR review | Participate in release planning and feature development/maintenance | Top level write access to relevant repository. Name entry in Maintainers file of the repository |
| [Owner](#owner) | Sponsor from 3 owners, helps drive the overall Volcano project | Drive the overall technical roadmap of the project and set priorities of activities in release planning | Volcano GitHub organization Admin access |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The removal of the Owner role creates an inconsistency in the summary table on line 13. The Maintainer entry still lists 'Sponsor from 2 owners' as a requirement. This should be updated to align with the new nomination and voting process described in the Maintainer section.


| [Maintainer](#maintainer) | Sponsor from 2 maintainers, shown good technical judgement in feature design/development and PR review | Participate in release planning and feature development/maintenance | Top level write access to relevant repository. Name entry in Maintainers file of the repository |

**Note :** It is mandatory for all Volcano community members to follow Volcano [Code of Conduct](./code_of_conduct.md).

Expand All @@ -21,7 +19,6 @@ This document gives a brief overview of the Volcano community roles with the req
Members are active participants in the community who contribute by authoring PRs,
reviewing issues/PRs or participate in community discussions on slack/mailing list.


### Requirements

- Sponsor from 2 approvers
Expand All @@ -32,6 +29,7 @@ reviewing issues/PRs or participate in community discussions on slack/mailing li
- Participating in community discussions on slack/mailing list
- Participate in Volcano community meetings

**NOTE:** In addition to contributing code to the community, if you are the contact person for an adopter, you can also apply to become a Member.

### Responsibilities and privileges

Expand All @@ -47,15 +45,13 @@ reviewing issues/PRs or participate in community discussions on slack/mailing li
Reviewers are active members who have basic experience and knowledge of the domain.
They have actively participated in the issue/PR reviews and have identified relevant issues during review.


### Requirements

- Sponsor from 2 maintainers
- Member for at least 2 months
- Have reviewed good number of PRs
- Have good codebase knowledge


### Responsibilities and Privileges

- Review code to maintain/improve code quality
Expand All @@ -68,15 +64,13 @@ They have actively participated in the issue/PR reviews and have identified rele
Approvers are active members who have good experience and knowledge of the domain.
They have actively participated in the issue/PR reviews and have identified relevant issues during review.


### Requirements

- Sponsor from 2 maintainers
- Reviewer for at least 2 months
- Have reviewed good number of PRs
- Have good codebase knowledge


### Responsibilities and Privileges

- Review code to maintain/improve code quality
Expand All @@ -92,10 +86,13 @@ Has overall knowledge of the project and features in the project.

### Requirements

- Sponsor from 2 owners
- Approver for at least 2 months
- Nominated by a project owner
- Good technical judgement in feature design/development
- Deep understanding of the technical goals and direction of the project.
- Deep understanding of the technical domain (specifically the language) of the project.
- Sustained contributions to design and direction by doing all of:
- Authoring and reviewing proposals
- Initiating, contributing and resolving discussions (e.g. emails, GitHub issues, meetings)
- Identifying subtle or complex issues in designs and implementation PRs
- Nominated by a maintainer and pass super-majority(two-thirds/ 66.66%) vote.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a missing space before the parenthesis, and the phrasing 'pass super-majority' is slightly awkward. Adding spaces around the slash also improves readability.

Suggested change
- Nominated by a maintainer and pass super-majority(two-thirds/ 66.66%) vote.
- Nominated by a maintainer and passing a super-majority (two-thirds / 66.66%) vote.


### Responsibilities and privileges

Expand All @@ -109,32 +106,26 @@ Has overall knowledge of the project and features in the project.
- Name entry in Maintainers file of the repository
- Participate & Drive design/development of multiple features

## Owner
## Inactive members

Owners are maintainers who have helped drive the overall project direction.
Has deep understanding of Volcano and related domain and facilitates major agreement in release planning
_Members are continuously active contributors in the community._

### Requirements
A core principle in maintaining a healthy community is encouraging active participation. It is inevitable that people's focuses will change over time and they are not expected to be actively contributing forever.

- Sponsor from 3 owners
- Maintainer for at least 2 months
- Nominated by a project owner
- Not opposed by any project owner
- Helped in driving the overall project
However, serving as a maintainer or approver for one of the Volcano GitHub organizations comes with an elevated set of permissions. These capabilities should not be used by those that are not familiar with the current state of the Volcano project.

### Responsibilities and Privileges
Therefore Maintainers or Approver who is extended period away from the project with no activity will be removed from the Volcano Github Organizations and will be required to go through the org membership process again after re-familiarizing themselves with the current state.

- Make technical decisions for the overall project
- Drive the overall technical roadmap of the project
- Set priorities of activities in release planning
- Guide and mentor all other community members
- Ensure all community members are following Code of Conduct
- Although given admin access to all repositories, make sure all PRs are properly reviewed and merged
- May get admin access to relevant repository based on requirement
- Participate & Drive design/development of multiple features
### How inactivity is measured

Inactive members are defined as members of one of the Volcano Organizations with **no** contributions across any organization within 18 months. This is measured by the CNCF [DevStats project].

**Note :** These roles are applicable only for Volcano github organization and repositories. Currently Volcano doesn't have a formal process for review and acceptance into these roles. We will come-up with a process soon.
**Note:** Devstats does not take into account non-code contributions. If a non-code contributing member is accidentally removed this way, they may open an issue to quickly be re-instated.

After an extended period away from the project with no activity those members would need to re-familiarize themselves with the current state before being able to contribute effectively.


**Note :** These roles are applicable only for Volcano github organization and repositories. Currently Volcano doesn't have a formal process for review and acceptance into these roles. We will come-up with a process soon.

[two-factor authentication]: https://help.github.com/articles/about-two-factor-authentication
[Devstats project]: https://volcano.devstats.cncf.io/